[#7934] Fix missing ActiveStorage attachment uploads #7953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
7934-fix-unsaved-attachments
branch
from
38b0f01
to
85823c7
Compare
The after commit hooks don't seem to be firing in some cases resulting in attachments not being uploaded after the attachment and its file blob record being saved. This change ensures the callback hook is fired if the `ActiveStorage` service doesn't have the blob. Fixes #7934
gbp
force-pushed
the
7934-fix-unsaved-attachments
branch
from
85823c7
to
342c539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7934
What does this do?
Fix missing ActiveStorage attachment uploads
Why was this needed?
The after commit hooks don't seem to be firing in some cases resulting in attachments not being uploaded after the attachment and its file blob record being saved.